Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

layers: Add 01912, 01913 #5277

Merged
merged 3 commits into from
Feb 17, 2023
Merged

layers: Add 01912, 01913 #5277

merged 3 commits into from
Feb 17, 2023
+87 −0

Conversation

ncesario-lunarg
Copy link
Contributor

Check to see that each "EndLabel" has a corresponding "BeginLabel."

Closes #5230.

@ncesario-lunarg ncesario-lunarg requested a review from a team as a code owner February 13, 2023 23:35
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 19975.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 10672 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 10672 aborted.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 20239.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 10681 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 10681 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 20749.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 10705 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 10705 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 21795.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 10741 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 10741 failed.

artem-lunarg
artem-lunarg reviewed Feb 16, 2023
View reviewed changes
tests/vklayertests_others.cpp
}
ASSERT_NO_FATAL_FAILURE(InitState());

auto vkCmdBeginDebugUtilsLabelEXT = reinterpret_cast<PFN_vkCmdBeginDebugUtilsLabelEXT>(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can we use the templated version? As a bonus it will also check for null result.

    auto vkCmdBeginDebugUtilsLabelEXT = GetDeviceProcAddr<PFN_vkCmdBeginDebugUtilsLabelEXT>("vkCmdBeginDebugUtilsLabelEXT");
    auto vkCmdEndDebugUtilsLabelEXT = GetDeviceProcAddr<PFN_vkCmdEndDebugUtilsLabelEXT>("vkCmdEndDebugUtilsLabelEXT");

artem-lunarg
artem-lunarg reviewed Feb 16, 2023
View reviewed changes
tests/vktestbinding.h
@@ -86,6 +86,9 @@ class Handle {
const T &handle() const noexcept { return handle_; }
bool initialized() const noexcept { return (handle_ != T{}); }

operator T() const noexcept { return handle(); }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@artem-lunarg artem-lunarg mentioned this pull request Feb 16, 2023
Closed
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 22449.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 10757 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 10757 passed.

@juan-lunarg
Copy link
Contributor

rebase on main to address CI issues

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 22791.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 10767 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 10767 passed.

@ncesario-lunarg ncesario-lunarg merged commit a906446 into KhronosGroup:main Feb 17, 2023
@ncesario-lunarg ncesario-lunarg deleted the issue-5230 branch February 17, 2023 00:14
blueboxd pushed a commit to blueboxd/angle that referenced this pull request Mar 1, 2023
@y-novikov
Suppress VUID-vkCmdEndDebugUtilsLabelEXT-commandBuffer-01912
dd6d830 
New VUID added in
KhronosGroup/Vulkan-ValidationLayers#5277

Bug: chromium:1420265
Change-Id: I139815fdfd90439c5a2ea79e467a60ba54ecbc0e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4296799
Commit-Queue: Corentin Wallez <[email protected]>
Reviewed-by: Corentin Wallez <[email protected]>
Commit-Queue: Yuly Novikov <[email protected]>
Commit-Queue: Roman Lavrov <[email protected]>
Reviewed-by: Roman Lavrov <[email protected]>
@jimblandy jimblandy mentioned this pull request May 31, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artem-lunarg artem-lunarg artem-lunarg approved these changes

@spencer-lunarg spencer-lunarg spencer-lunarg approved these changes

@juan-lunarg juan-lunarg juan-lunarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing validation check around mismatched debug/end debug markers?
5 participants
@ncesario-lunarg @ci-tester-lunarg @juan-lunarg @spencer-lunarg @artem-lunarg